]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i2c: cpm: Remove linux,i2c-index conversion from be32
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Wed, 6 Dec 2023 22:24:03 +0000 (23:24 +0100)
committerWolfram Sang <wsa@kernel.org>
Thu, 18 Jan 2024 20:10:42 +0000 (21:10 +0100)
sparse reports an error on some data that gets converted from be32.

That's because that data is typed u32 instead of __be32.

The type is correct, the be32_to_cpu() conversion is not.

Remove the conversion.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312042210.QL4DA8Av-lkp@intel.com/
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-By: Jochen Friedrich <jochen@scram.de>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-cpm.c

index 9a664abf734d6627889a33f7f0729c384a8322e0..4404b4aac6765b15b27840fd0a43ee8551f43aed 100644 (file)
@@ -658,7 +658,7 @@ static int cpm_i2c_probe(struct platform_device *ofdev)
        /* register new adapter to i2c module... */
 
        data = of_get_property(ofdev->dev.of_node, "linux,i2c-index", &len);
-       cpm->adap.nr = (data && len == 4) ? be32_to_cpup(data) : -1;
+       cpm->adap.nr = (data && len == 4) ? *data : -1;
        result = i2c_add_numbered_adapter(&cpm->adap);
 
        if (result < 0)