]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: simplify xfsaild_resubmit_item
authorChristoph Hellwig <hch@lst.de>
Tue, 31 Dec 2024 06:39:29 +0000 (06:39 +0000)
committerChristoph Hellwig <hch@lst.de>
Sat, 11 Jan 2025 05:21:43 +0000 (06:21 +0100)
Since commit acc8f8628c37 ("xfs: attach dquot buffer to dquot log item
buffer") all buf items that use bp->b_li_list are explicitly checked for
in the branch to just clears XFS_LI_FAILED.  Remove the dead arm that
calls xfs_clear_li_failed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
fs/xfs/xfs_trans_ail.c

index f56d62dced97b1b6a9c12b0edb3a19b5e9a8cd3b..0fcb1828e598fbbe5ddeb88b2ff443da389bf0f6 100644 (file)
@@ -359,13 +359,8 @@ xfsaild_resubmit_item(
        }
 
        /* protected by ail_lock */
-       list_for_each_entry(lip, &bp->b_li_list, li_bio_list) {
-               if (bp->b_flags & (_XBF_INODES | _XBF_DQUOTS))
-                       clear_bit(XFS_LI_FAILED, &lip->li_flags);
-               else
-                       xfs_clear_li_failed(lip);
-       }
-
+       list_for_each_entry(lip, &bp->b_li_list, li_bio_list)
+               clear_bit(XFS_LI_FAILED, &lip->li_flags);
        xfs_buf_unlock(bp);
        return XFS_ITEM_SUCCESS;
 }