]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/nouveau: fix bad ret code in nouveau_bo_move_prep
authorShuhao Fu <sfual@cse.ust.hk>
Tue, 7 Oct 2025 16:17:09 +0000 (00:17 +0800)
committerDanilo Krummrich <dakr@kernel.org>
Tue, 7 Oct 2025 20:15:25 +0000 (22:15 +0200)
In `nouveau_bo_move_prep`, if `nouveau_mem_map` fails, an error code
should be returned. Currently, it returns zero even if vmm addr is not
correctly mapped.

Cc: stable@vger.kernel.org
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Shuhao Fu <sfual@cse.ust.hk>
Fixes: 9ce523cc3bf2 ("drm/nouveau: separate buffer object backing memory from nvkm structures")
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nouveau_bo.c

index b96f0555ca14535f1b39d8976924ec6db7047759..f26562eafffc86c90822b9dd0bfcd2c13c396848 100644 (file)
@@ -929,7 +929,7 @@ done:
                nvif_vmm_put(vmm, &old_mem->vma[1]);
                nvif_vmm_put(vmm, &old_mem->vma[0]);
        }
-       return 0;
+       return ret;
 }
 
 static int