]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Bluetooth: btnxpuart: Uses threaded IRQ for host wakeup handling
authorNeeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Mon, 4 Aug 2025 10:30:15 +0000 (16:00 +0530)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 15 Aug 2025 14:13:26 +0000 (10:13 -0400)
This replaces devm_request_irq() with devm_request_threaded_irq().

On iMX93 11x11 EVK platform, the BT chip's BT_WAKE_OUT pin is connected
to an I2C GPIO expander instead of directly been connected to iMX GPIO.

When I2C GPIO expander's (PCAL6524) host driver receives an interrupt on
it's INTR line, the driver's interrupt handler needs to query the
interrupt source with PCAL6524 first, and then call the actual interrupt
handler, in this case the IRQ handler in BTNXPUART.

In order to handle interrupts when such I2C GPIO expanders are between
the host and interrupt source, devm_request_threaded_irq() is needed.

This commit also removes the IRQF_TRIGGER_FALLING flag, to allow setting
the IRQ trigger type from the device tree setting instead of hardcoding
in the driver.

Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Reviewed-by: Sherry Sun <sherry.sun@nxp.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btnxpuart.c

index 73a4a325c8671b34aa414553f2ee107128915109..76e7f857fb7d9a4d03b889cce5ee4f5903eff6e6 100644 (file)
@@ -543,10 +543,10 @@ static int ps_setup(struct hci_dev *hdev)
        }
 
        if (psdata->wakeup_source) {
-               ret = devm_request_irq(&serdev->dev, psdata->irq_handler,
-                                       ps_host_wakeup_irq_handler,
-                                       IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
-                                       dev_name(&serdev->dev), nxpdev);
+               ret = devm_request_threaded_irq(&serdev->dev, psdata->irq_handler,
+                                               NULL, ps_host_wakeup_irq_handler,
+                                               IRQF_ONESHOT,
+                                               dev_name(&serdev->dev), nxpdev);
                if (ret)
                        bt_dev_info(hdev, "error setting wakeup IRQ handler, ignoring\n");
                disable_irq(psdata->irq_handler);