PCI: cadence: Lower severity of message when phy-names property is absent in DTS
authorBartosz Wawrzyniak <bwawrzyn@cisco.com>
Fri, 18 Oct 2024 11:30:43 +0000 (11:30 +0000)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 13 Nov 2024 17:25:15 +0000 (17:25 +0000)
The "phy-names" property is optional, so the message indicating its
absence during the probe should be of "info" severity rather than
"error" severity.

Link: https://lore.kernel.org/r/20241018113045.2050295-1-bwawrzyn@cisco.com
Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@cisco.com>
[kwilczynski: update log messages wording, commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/cadence/pcie-cadence.c

index 4251fac5e31065cd8651da7a022fac7f945664da..204e045aed8c3303c858f16dda60c80411afea9d 100644 (file)
@@ -197,7 +197,7 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie)
 
        phy_count = of_property_count_strings(np, "phy-names");
        if (phy_count < 1) {
-               dev_err(dev, "no phy-names.  PHY will not be initialized\n");
+               dev_info(dev, "no \"phy-names\" property found; PHY will not be initialized\n");
                pcie->phy_count = 0;
                return 0;
        }
@@ -260,7 +260,7 @@ static int cdns_pcie_resume_noirq(struct device *dev)
 
        ret = cdns_pcie_enable_phy(pcie);
        if (ret) {
-               dev_err(dev, "failed to enable phy\n");
+               dev_err(dev, "failed to enable PHY\n");
                return ret;
        }