]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
usb: gadget: u_serial: remove some dead code
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 25 Jun 2025 15:21:53 +0000 (10:21 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 28 Jun 2025 15:24:17 +0000 (17:24 +0200)
There is no need to check if "port" is NULL.  We already verified that it
is non-NULL.  It's a stack variable and can't be modified by a different
thread.  Delete this dead code.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Prashanth K <prashanth.k@oss.qualcomm.com>
Link: https://lore.kernel.org/r/685c1413.050a0220.1a8223.d0b9@mx.google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/u_serial.c

index ab544f6824befa3a90922e9f16c8255a1d9d9fa9..96756a489d6ac771207f5f55f58a8e2c4fe511a0 100644 (file)
@@ -1505,13 +1505,7 @@ void gserial_suspend(struct gserial *gser)
                spin_unlock_irqrestore(&serial_port_lock, flags);
                if (!gserial_wakeup_host(gser))
                        return;
-
-               /* Check if port is valid after acquiring lock back */
                spin_lock_irqsave(&serial_port_lock, flags);
-               if (!port) {
-                       spin_unlock_irqrestore(&serial_port_lock, flags);
-                       return;
-               }
        }
 
        spin_lock(&port->port_lock);