IB/mlx4: Fix Coverity issues

Signed-off-by: Itai Garbi <igarbi@mellanox.com>
Signed-off-by: Hadar Hen Zion <hadarh@mellanox.com>
(Ported from Mellanox OFED 2.4)

Signed-off-by: Mukesh Kacker <mukesh.kacker@oracle.com>

diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
index afcbd1025ffe674649d39a24572d35856923a4e6..50418728e6798e6fa93a37b39b8ec7309cea7f4e 100644 (file)
--- a/drivers/infiniband/hw/mlx4/cq.c
+++ b/drivers/infiniband/hw/mlx4/cq.c
@@ -777,6 +777,7 @@ repoll:
                switch (cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) {
                case MLX4_OPCODE_RDMA_WRITE_IMM:
                        wc->wc_flags |= IB_WC_WITH_IMM;
+                       /* fall through */
                case MLX4_OPCODE_RDMA_WRITE:
                        wc->opcode    = IB_WC_RDMA_WRITE;
                        break;

diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
index eb4057dd487c19bc08d73370f22422df8ad8aa94..975d488b19e6d8bd160a3c582fc3f8c021640094 100644 (file)
--- a/drivers/infiniband/hw/mlx4/qp.c
+++ b/drivers/infiniband/hw/mlx4/qp.c
@@ -725,7 +725,7 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
                int shift;
                int n;
 
-               if (ib_copy_from_udata(&ucmd, udata, sizeof ucmd)) {
+               if (!udata || ib_copy_from_udata(&ucmd, udata, sizeof(ucmd))) {
                        err = -EFAULT;
                        goto err;
                }