controller list argument is required in attach-ns/detach-ns commands

Empty controller-id list in the ioctl call for attach/detach of namespace results effectively in no operation, yet the nvme cli reports falsely success. The controller id list must be specified with at least 1 controller in the list.

diff --git a/nvme.c b/nvme.c
index f4218a3198c8f3110109d9a7241f09c9f1bf3c4e..e2e2abf15b67c661f531cb29a90e173df7fdde72 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -1058,7 +1058,7 @@ static int nvme_attach_ns(int argc, char **argv, int attach, const char *desc, s
        __u16 ctrlist[2048];
 
        const char *namespace_id = "namespace to attach";
-       const char *cont = "optional comma-sep controller id list";
+       const char *cont = "comma-sep controller id list";
 
        struct config {
                char  *cntlist;
@@ -1088,7 +1088,7 @@ static int nvme_attach_ns(int argc, char **argv, int attach, const char *desc, s
        }
 
        num = argconfig_parse_comma_sep_array(cfg.cntlist, list, 2047);
-       if (num == -1) {
+       if (num < 1) {
                fprintf(stderr, "%s: controller id list is required\n",
                                                cmd->name);
                err = -EINVAL;