]> www.infradead.org Git - nvme.git/commitdiff
wifi: iwlwifi: fix system commands group ordering
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Sun, 12 Nov 2023 14:36:20 +0000 (16:36 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 12 Nov 2023 19:34:19 +0000 (11:34 -0800)
The commands should be sorted inside the group definition.
Fix the ordering so we won't get following warning:
WARN_ON(iwl_cmd_groups_verify_sorted(trans_cfg))

Link: https://lore.kernel.org/regressions/2fa930bb-54dd-4942-a88d-05a47c8e9731@gmail.com/
Link: https://lore.kernel.org/linux-wireless/CAHk-=wix6kqQ5vHZXjOPpZBfM7mMm9bBZxi2Jh7XnaKCqVf94w@mail.gmail.com/
Fixes: b6e3d1ba4fcf ("wifi: iwlwifi: mvm: implement new firmware API for statistics")
Tested-by: Niklāvs Koļesņikovs <pinkflames.linux@gmail.com>
Tested-by: Damian Tometzki <damian@riscv-rocks.de>
Acked-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/wireless/intel/iwlwifi/mvm/ops.c

index fef86a8b41639381c1355f3df8e11b88f5696c05..1627b2f819db1dde8481e7c4275835a01087e403 100644 (file)
@@ -550,9 +550,9 @@ static const struct iwl_hcmd_names iwl_mvm_system_names[] = {
        HCMD_NAME(RFI_CONFIG_CMD),
        HCMD_NAME(RFI_GET_FREQ_TABLE_CMD),
        HCMD_NAME(SYSTEM_FEATURES_CONTROL_CMD),
-       HCMD_NAME(RFI_DEACTIVATE_NOTIF),
        HCMD_NAME(SYSTEM_STATISTICS_CMD),
        HCMD_NAME(SYSTEM_STATISTICS_END_NOTIF),
+       HCMD_NAME(RFI_DEACTIVATE_NOTIF),
 };
 
 /* Please keep this array *SORTED* by hex value.