igc: Fix NFC rules leak when driver is unloaded

If we have RFC rules in adapter->nfc_rule_list when the IGC driver
is unloaded, all rules are leaked. This patch fixes the issue by
introducing the helper igc_flush_nfc_rules() and calling it in
igc_remove(). It also updates igc_set_features() so is reuses the
new helper instead of re-implementing it.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index ad9217335a64c503734586e40e5db92cd7444e8e..0a6f880e353840185e0265c8dcfaf3c711b09f95 100644 (file)
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -2544,6 +2544,18 @@ void igc_del_nfc_rule(struct igc_adapter *adapter, struct igc_nfc_rule *rule)
        kfree(rule);
 }
 
+static void igc_flush_nfc_rules(struct igc_adapter *adapter)
+{
+       struct igc_nfc_rule *rule, *tmp;
+
+       spin_lock(&adapter->nfc_rule_lock);
+
+       list_for_each_entry_safe(rule, tmp, &adapter->nfc_rule_list, list)
+               igc_del_nfc_rule(adapter, rule);
+
+       spin_unlock(&adapter->nfc_rule_lock);
+}
+
 /**
  * igc_add_nfc_rule() - Add NFC rule
  * @adapter: Pointer to adapter
@@ -3967,19 +3979,8 @@ static int igc_set_features(struct net_device *netdev,
        if (!(changed & (NETIF_F_RXALL | NETIF_F_NTUPLE)))
                return 0;
 
-       if (!(features & NETIF_F_NTUPLE)) {
-               struct igc_nfc_rule *rule, *tmp;
-
-               spin_lock(&adapter->nfc_rule_lock);
-               list_for_each_entry_safe(rule, tmp,
-                                        &adapter->nfc_rule_list, list) {
-                       igc_disable_nfc_rule(adapter, rule);
-                       list_del(&rule->list);
-                       kfree(rule);
-               }
-               spin_unlock(&adapter->nfc_rule_lock);
-               adapter->nfc_rule_count = 0;
-       }
+       if (!(features & NETIF_F_NTUPLE))
+               igc_flush_nfc_rules(adapter);
 
        netdev->features = features;
 
@@ -5246,6 +5247,8 @@ static void igc_remove(struct pci_dev *pdev)
 
        pm_runtime_get_noresume(&pdev->dev);
 
+       igc_flush_nfc_rules(adapter);
+
        igc_ptp_stop(adapter);
 
        set_bit(__IGC_DOWN, &adapter->state);