net: ipa: introduce ipa_version_valid()

Define and use a new function that just validates the version
defined in configuration data.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
index 9915603ed10babaeac41daefa89ed1479b0b3faf..cbd39e4667a3276c30dc64d804dbd5036a7c145a 100644 (file)
--- a/drivers/net/ipa/ipa_main.c
+++ b/drivers/net/ipa/ipa_main.c
@@ -639,6 +639,27 @@ static void ipa_validate_build(void)
 #endif /* IPA_VALIDATE */
 }
 
+static bool ipa_version_valid(enum ipa_version version)
+{
+       switch (version) {
+       case IPA_VERSION_3_0:
+       case IPA_VERSION_3_1:
+       case IPA_VERSION_3_5:
+       case IPA_VERSION_3_5_1:
+       case IPA_VERSION_4_0:
+       case IPA_VERSION_4_1:
+       case IPA_VERSION_4_2:
+       case IPA_VERSION_4_5:
+       case IPA_VERSION_4_7:
+       case IPA_VERSION_4_9:
+       case IPA_VERSION_4_11:
+               return true;
+
+       default:
+               return false;
+       }
+}
+
 /**
  * ipa_probe() - IPA platform driver probe function
  * @pdev:      Platform device pointer
@@ -676,11 +697,15 @@ static int ipa_probe(struct platform_device *pdev)
        /* Get configuration data early; needed for clock initialization */
        data = of_device_get_match_data(dev);
        if (!data) {
-               /* This is really IPA_VALIDATE (should never happen) */
                dev_err(dev, "matched hardware not supported\n");
                return -ENODEV;
        }
 
+       if (!ipa_version_valid(data->version)) {
+               dev_err(dev, "invalid IPA version\n");
+               return -EINVAL;
+       }
+
        /* If we need Trust Zone, make sure it's available */
        modem_init = of_property_read_bool(dev->of_node, "modem-init");
        if (!modem_init)