net: ethernet: mtk_wed: Fix missing of_node_put() in mtk_wed_wo_hardware_init()

The np needs to be released through of_node_put() in the error handling
path of mtk_wed_wo_hardware_init().

Fixes: 799684448e3e ("net: ethernet: mtk_wed: introduce wed wo support")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221205034339.112163-1-yuancan@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/mediatek/mtk_wed_wo.c b/drivers/net/ethernet/mediatek/mtk_wed_wo.c
index a219da85f4dbaddf620a5f5011645b8525db6210..a0a39643caf74a7e3cc2f6bed78e117de2bc3c92 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_wed_wo.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed_wo.c
@@ -408,8 +408,10 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo)
                return -ENODEV;
 
        wo->mmio.regs = syscon_regmap_lookup_by_phandle(np, NULL);
-       if (IS_ERR_OR_NULL(wo->mmio.regs))
-               return PTR_ERR(wo->mmio.regs);
+       if (IS_ERR(wo->mmio.regs)) {
+               ret = PTR_ERR(wo->mmio.regs);
+               goto error_put;
+       }
 
        wo->mmio.irq = irq_of_parse_and_map(np, 0);
        wo->mmio.irq_mask = MTK_WED_WO_ALL_INT_MASK;
@@ -457,7 +459,8 @@ mtk_wed_wo_hardware_init(struct mtk_wed_wo *wo)
 
 error:
        devm_free_irq(wo->hw->dev, wo->mmio.irq, wo);
-
+error_put:
+       of_node_put(np);
        return ret;
 }