ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized

In function rt5651_i2c_probe(), local variable "ret" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement. This is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index 75994297c8964a749ea5db14c75b86e6b272b96b..29b2d60076b022f824032c0e9aed87b18bbc4148 100644 (file)
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -2181,6 +2181,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c,
 {
        struct rt5651_priv *rt5651;
        int ret;
+       int err;
 
        rt5651 = devm_kzalloc(&i2c->dev, sizeof(*rt5651),
                                GFP_KERNEL);
@@ -2197,7 +2198,10 @@ static int rt5651_i2c_probe(struct i2c_client *i2c,
                return ret;
        }
 
-       regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret);
+       err = regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret);
+       if (err)
+               return err;
+
        if (ret != RT5651_DEVICE_ID_VALUE) {
                dev_err(&i2c->dev,
                        "Device with ID register %#x is not rt5651\n", ret);