]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
Bluetooth: hci_qca: fix a NULL-pointer derefence at shutdown
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 31 Jul 2024 15:20:50 +0000 (17:20 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Wed, 7 Aug 2024 20:35:53 +0000 (16:35 -0400)
Unlike qca_regulator_init(), qca_power_shutdown() may be called for
QCA_ROME which does not have qcadev->bt_power assigned. Add a
NULL-pointer check before dereferencing the struct qca_power pointer.

Fixes: eba1718717b0 ("Bluetooth: hci_qca: make pwrseq calls the default if available")
Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Closes: https://lore.kernel.org/linux-bluetooth/su3wp6s44hrxf4ijvsdfzbvv4unu4ycb7kkvwbx6ltdafkldir@4g7ydqm2ap5j/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_qca.c

index 2baed7d0f4799d3a745b33186930c79dd77399c2..45adc1560d949af8aff2ed7cdc717cd9c5c228d5 100644 (file)
@@ -2160,7 +2160,7 @@ static void qca_power_shutdown(struct hci_uart *hu)
        qcadev = serdev_device_get_drvdata(hu->serdev);
        power = qcadev->bt_power;
 
-       if (power->pwrseq) {
+       if (power && power->pwrseq) {
                pwrseq_power_off(power->pwrseq);
                set_bit(QCA_BT_OFF, &qca->flags);
                return;