maple_tree: refine mab_calc_split function

Invert the conditional judgment of the mid_split, to focus the return
statement in the last statement, which is easier to understand and for
better readability.

Link: https://lkml.kernel.org/r/20221221060058.609003-8-vernon2gm@gmail.com
Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index d4554c11ec155609554229c4cbd2f7a0fadd7b7f..94f0053ec3e0a39745e74e05b9e0683e8c2c084d 100644 (file)
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -1882,10 +1882,9 @@ static inline int mab_calc_split(struct ma_state *mas,
 
        /* Avoid ending a node on a NULL entry */
        split = mab_no_null_split(bn, split, slot_count);
-       if (!(*mid_split))
-               return split;
 
-       *mid_split = mab_no_null_split(bn, *mid_split, slot_count);
+       if (unlikely(*mid_split))
+               *mid_split = mab_no_null_split(bn, *mid_split, slot_count);
 
        return split;
 }