usb: phy: generic: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220922133323.2135494-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index 34b9f8140187182f334014125c1f9eb745c627b0..3dc5c04e7cbf91bedf49d6387d609c6239d76ee0 100644 (file)
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -230,12 +230,9 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop)
                err = PTR_ERR_OR_ZERO(nop->gpiod_vbus);
        }
 
-       if (err == -EPROBE_DEFER)
-               return -EPROBE_DEFER;
-       if (err) {
-               dev_err(dev, "Error requesting RESET or VBUS GPIO\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(dev, err,
+                                    "Error requesting RESET or VBUS GPIO\n");
        if (nop->gpiod_reset)
                gpiod_direction_output(nop->gpiod_reset, 1);