devlink: devl_resource_register(): differentiate error codes

Differentiate error codes of devl_resource_register().

Replace one of -EINVAL exit paths by -EEXIST. This should aid developers
introducing new resources and registering them in the wrong order.

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/20241023131248.27192-4-przemyslaw.kitszel@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/devlink/resource.c b/net/devlink/resource.c
index 5ce05e94f48410137af07b719e633b07d94de109..96c0ff24b65abc52e53cbc52004e3012771ff0c1 100644 (file)
--- a/net/devlink/resource.c
+++ b/net/devlink/resource.c
@@ -345,7 +345,7 @@ int devl_resource_register(struct devlink *devlink,
 
        resource = devlink_resource_find(devlink, NULL, resource_id);
        if (resource)
-               return -EINVAL;
+               return -EEXIST;
 
        resource = kzalloc(sizeof(*resource), GFP_KERNEL);
        if (!resource)