]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
add comment on openconnect__inet_aton(), which is not 100% compatible with "real...
authorDaniel Lenski <dlenski@gmail.com>
Thu, 25 Apr 2019 16:29:06 +0000 (11:29 -0500)
committerDaniel Lenski <dlenski@gmail.com>
Wed, 20 May 2020 01:38:32 +0000 (18:38 -0700)
Signed-off-by: Daniel Lenski <dlenski@gmail.com>
compat.c

index 777739a3d7a472070d2b4ce42c87bba8e7865dc3..1246730b8f0d64d542069817ea3f5897b5c488cb 100644 (file)
--- a/compat.c
+++ b/compat.c
@@ -185,6 +185,10 @@ char *openconnect__strndup(const char *s, size_t n)
 #endif
 
 #ifndef HAVE_INET_ATON
+/* XX: unlike "real" inet_aton(), inet_pton() only accepts dotted-decimal notation, not
+ * looser/rarer formats like 32-bit decimal values. For example, inet_aton() accepts both
+ * "127.0.0.1" and "2130706433" as equivalent, but inet_pton() only accepts the former.
+ */
 int openconnect__inet_aton(const char *cp, struct in_addr *addr)
 {
        return inet_pton(AF_INET, cp, addr);