]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mm/khugepaged: Stop using vma linked list
authorLiam R. Howlett <Liam.Howlett@Oracle.com>
Mon, 4 Jan 2021 19:56:58 +0000 (14:56 -0500)
committerLiam R. Howlett <Liam.Howlett@oracle.com>
Mon, 14 Mar 2022 18:49:47 +0000 (14:49 -0400)
Use vma iterator & find_vma() instead of vma linked list.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
mm/huge_memory.c
mm/khugepaged.c

index 406a3c28c0266be6e7fb7cca1f79c6daa78de024..1d23f6fee0cc5a7e02936c9e79e8d73dbf094295 100644 (file)
@@ -2270,11 +2270,11 @@ void vma_adjust_trans_huge(struct vm_area_struct *vma,
        split_huge_pmd_if_needed(vma, end);
 
        /*
-        * If we're also updating the vma->vm_next->vm_start,
+        * If we're also updating the next vma vm_start,
         * check if we need to split it.
         */
        if (adjust_next > 0) {
-               struct vm_area_struct *next = vma->vm_next;
+               struct vm_area_struct *next = find_vma(vma->vm_mm, vma->vm_end);
                unsigned long nstart = next->vm_start;
                nstart += adjust_next;
                split_huge_pmd_if_needed(next, nstart);
index 7507b786f1a0650c6bc6ba379b8612aab1ef0a61..92a3f616605b21df62b31eb11f5f2945078a2a13 100644 (file)
@@ -2093,10 +2093,12 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages,
        __releases(&khugepaged_mm_lock)
        __acquires(&khugepaged_mm_lock)
 {
+       struct vma_iterator vmi;
        struct mm_slot *mm_slot;
        struct mm_struct *mm;
        struct vm_area_struct *vma;
        int progress = 0;
+       unsigned long address;
 
        VM_BUG_ON(!pages);
        lockdep_assert_held(&khugepaged_mm_lock);
@@ -2120,11 +2122,14 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages,
        vma = NULL;
        if (unlikely(!mmap_read_trylock(mm)))
                goto breakouterloop_mmap_lock;
-       if (likely(!khugepaged_test_exit(mm)))
-               vma = find_vma(mm, khugepaged_scan.address);
 
        progress++;
-       for (; vma; vma = vma->vm_next) {
+       if (unlikely(khugepaged_test_exit(mm)))
+               goto breakouterloop;
+
+       address = khugepaged_scan.address;
+       vma_iter_init(&vmi, mm, address);
+       for_each_vma(vmi, vma) {
                unsigned long hstart, hend;
 
                cond_resched();