]> www.infradead.org Git - nvme.git/commitdiff
rtc: ab-eoz9: don't fail temperature reads on undervoltage notification
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 22 Nov 2024 10:10:30 +0000 (11:10 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 25 Nov 2024 22:34:12 +0000 (23:34 +0100)
The undervoltage flags reported by the RTC are useful to know if the
time and date are reliable after a reboot. Although the threshold VLOW1
indicates that the thermometer has been shutdown and time compensation
is off, it doesn't mean that the temperature readout is currently
impossible.

As the system is running, the RTC voltage is now fully established and
we can read the temperature.

Fixes: 67075b63cce2 ("rtc: add AB-RTCMC-32.768kHz-EOZ9 RTC support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://lore.kernel.org/r/20241122101031.68916-3-maxime.chevallier@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ab-eoz9.c

index 84c5f77808c574159198a1f37a6bd8b60af97cf0..d2b60487d4623e529c1e7adcd0d233af8b6c14df 100644 (file)
@@ -394,13 +394,6 @@ static int abeoz9z3_temp_read(struct device *dev,
        if (ret < 0)
                return ret;
 
-       if ((val & ABEOZ9_REG_CTRL_STATUS_V1F) ||
-           (val & ABEOZ9_REG_CTRL_STATUS_V2F)) {
-               dev_err(dev,
-                       "thermometer might be disabled due to low voltage\n");
-               return -EINVAL;
-       }
-
        switch (attr) {
        case hwmon_temp_input:
                ret = regmap_read(regmap, ABEOZ9_REG_REG_TEMP, &val);