]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
ext4/01{2,9}: fix invalid filesystem option 'journal'
authorLuis Henriques (SUSE) <luis.henriques@linux.dev>
Mon, 1 Apr 2024 09:57:08 +0000 (10:57 +0100)
committerZorro Lang <zlang@kernel.org>
Wed, 3 Apr 2024 11:01:42 +0000 (19:01 +0800)
Creating an ext4 filesystem using '-O journal' will fail with:

    Invalid filesystem option set: journal

Fix it by replacing it by '-O has_journal', which ensures the filesystem
(ext3 or ext4) is created with a journal.  While there, also redirect stderr
and stdout to the full log.

Signed-off-by: "Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tests/ext4/012
tests/ext4/019

index c49e8ef4483bb593a1adccd6c85c6e3d484ac9dd..358874a1caf160ef2c6c2c30bc19180c41be07c5 100755 (executable)
@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir"
 TESTFILE="${TESTDIR}/testfile"
 
 echo "+ create scratch fs"
-_scratch_mkfs_ext4 -O journal > /dev/null 2>&1
+_scratch_mkfs -O has_journal >> $seqres.full 2>&1
 
 echo "+ mount fs image"
 _scratch_mount
index ab5f50c66b6f39246fa69a7e235549ad3198b842..f0514093981b8a368d172a2c63571cb5633c7931 100755 (executable)
@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir"
 TESTFILE="${TESTDIR}/testfile"
 
 echo "+ create scratch fs"
-_scratch_mkfs_ext4 -O journal > /dev/null 2>&1
+_scratch_mkfs -O has_journal >> $seqres.full 2>&1
 
 echo "+ mount fs image"
 _scratch_mount