]> www.infradead.org Git - users/hch/misc.git/commitdiff
tools: ynl-gen: move local vars after the opening bracket
authorJakub Kicinski <kuba@kernel.org>
Mon, 14 Apr 2025 21:18:45 +0000 (14:18 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:09:41 +0000 (18:09 -0700)
The "function writing helper" tries to put local variables
between prototype and the opening bracket. Clearly wrong,
but up until now nothing actually uses it to write local
vars so it wasn't noticed.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250414211851.602096-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/pyynl/ynl_gen_c.py

index 305f5696bc4f28bf1c0549434cea452e635e64de..662a925bd9e11a235003fa412b1aa14135d2bbea 100755 (executable)
@@ -1399,9 +1399,9 @@ class CodeWriter:
 
     def write_func(self, qual_ret, name, body, args=None, local_vars=None):
         self.write_func_prot(qual_ret=qual_ret, name=name, args=args)
+        self.block_start()
         self.write_func_lvar(local_vars=local_vars)
 
-        self.block_start()
         for line in body:
             self.p(line)
         self.block_end()