]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/i915/dp: Fix passing the correct DPCD_REV for drm_dp_set_phy_test_pattern
authorKhaled Almahallawy <khaled.almahallawy@intel.com>
Wed, 13 Dec 2023 21:15:42 +0000 (13:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Jan 2024 17:51:09 +0000 (18:51 +0100)
[ Upstream commit 2bd7a06a1208aaacb4e7a2a5436c23bce8d70801 ]

Using link_status to get DPCD_REV fails when disabling/defaulting
phy pattern. Use intel_dp->dpcd to access DPCD_REV correctly.

Fixes: 8cdf72711928 ("drm/i915/dp: Program vswing, pre-emphasis, test-pattern")
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231213211542.3585105-3-khaled.almahallawy@intel.com
(cherry picked from commit 3ee302ec22d6e1d7d1e6d381b0d507ee80f2135c)
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/i915/display/intel_dp.c

index 6cc125857808827c3724649d3277de06ce1d97b6..a0c04b9d9c7396ed5697314988c450f149db2a4f 100644 (file)
@@ -3275,7 +3275,7 @@ static void intel_dp_process_phy_request(struct intel_dp *intel_dp,
                          intel_dp->train_set, crtc_state->lane_count);
 
        drm_dp_set_phy_test_pattern(&intel_dp->aux, data,
-                                   link_status[DP_DPCD_REV]);
+                                   intel_dp->dpcd[DP_DPCD_REV]);
 }
 
 static u8 intel_dp_autotest_phy_pattern(struct intel_dp *intel_dp)