thermal/drivers/qcom/tsens: Init debugfs only with successful probe

Calibrate and tsens_register can fail or PROBE_DEFER. This will cause a
double or a wrong init of the debugfs information. Init debugfs only
with successful probe fixing warning about directory already present.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Link: https://lore.kernel.org/r/20221022125657.22530-2-ansuelsmth@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>

diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index b7d978295b2f9d131ada00a1db87584cb466c7fa..3ac780404c72ce41602eb4dc81c48d763dd7b83e 100644 (file)
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -939,8 +939,6 @@ int __init init_common(struct tsens_priv *priv)
        if (tsens_version(priv) >= VER_0_1)
                tsens_enable_irq(priv);
 
-       tsens_debug_init(op);
-
 err_put_device:
        put_device(&op->dev);
        return ret;
@@ -1182,7 +1180,11 @@ static int tsens_probe(struct platform_device *pdev)
                }
        }
 
-       return tsens_register(priv);
+       ret = tsens_register(priv);
+       if (!ret)
+               tsens_debug_init(pdev);
+
+       return ret;
 }
 
 static int tsens_remove(struct platform_device *pdev)