]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mm/hugetlb: remove unused local variable dst_entry in copy_hugetlb_page_range()
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Mon, 22 Aug 2022 08:25:25 +0000 (10:25 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 26 Aug 2022 05:02:56 +0000 (22:02 -0700)
Commit a0e4f7b82610 ("mm/hugetlb: make detecting shared pte more
reliable") modifies copy_hugetlb_page_range() such that
huge_ptep_get(dst_pte) and the local variable dst_entry is not used
explicitly in this function.

Remove this unused local variable dst_entry in copy_hugetlb_page_range().
No functional change.

Link: https://lkml.kernel.org/r/20220822082525.26071-1-lukas.bulwahn@gmail.com
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb.c

index cf686c7b7e52dafd1a62af6819783fcbac4ebbea..de12ab6234eb5c8224da8576900cdee8f4928349 100644 (file)
@@ -4750,7 +4750,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
                            struct vm_area_struct *dst_vma,
                            struct vm_area_struct *src_vma)
 {
-       pte_t *src_pte, *dst_pte, entry, dst_entry;
+       pte_t *src_pte, *dst_pte, entry;
        struct page *ptepage;
        unsigned long addr;
        bool cow = is_cow_mapping(src_vma->vm_flags);
@@ -4810,7 +4810,6 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
                src_ptl = huge_pte_lockptr(h, src, src_pte);
                spin_lock_nested(src_ptl, SINGLE_DEPTH_NESTING);
                entry = huge_ptep_get(src_pte);
-               dst_entry = huge_ptep_get(dst_pte);
 again:
                if (huge_pte_none(entry)) {
                        /*
@@ -4893,7 +4892,7 @@ again:
                                        restore_reserve_on_error(h, dst_vma, addr,
                                                                new);
                                        put_page(new);
-                                       /* dst_entry won't change as in child */
+                                       /* huge_ptep of dst_pte won't change as in child */
                                        goto again;
                                }
                                hugetlb_install_page(dst_vma, dst_pte, addr, new);