dm cache metadata: return bool from __superblock_all_zeroes

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

diff --git a/drivers/md/dm-cache-metadata.c b/drivers/md/dm-cache-metadata.c
index 1af7255bbffb547aa67db8b1f38bf99b2ff87094..2262b4e57a28afec2811b11d42b4a6f84328705a 100644 (file)
--- a/drivers/md/dm-cache-metadata.c
+++ b/drivers/md/dm-cache-metadata.c
@@ -198,7 +198,7 @@ static int superblock_lock(struct dm_cache_metadata *cmd,
 
 /*----------------------------------------------------------------*/
 
-static int __superblock_all_zeroes(struct dm_block_manager *bm, int *result)
+static int __superblock_all_zeroes(struct dm_block_manager *bm, bool *result)
 {
        int r;
        unsigned i;
@@ -214,10 +214,10 @@ static int __superblock_all_zeroes(struct dm_block_manager *bm, int *result)
                return r;
 
        data_le = dm_block_data(b);
-       *result = 1;
+       *result = true;
        for (i = 0; i < sb_block_size; i++) {
                if (data_le[i] != zero) {
-                       *result = 0;
+                       *result = false;
                        break;
                }
        }
@@ -411,7 +411,8 @@ bad:
 static int __open_or_format_metadata(struct dm_cache_metadata *cmd,
                                     bool format_device)
 {
-       int r, unformatted;
+       int r;
+       bool unformatted = false;
 
        r = __superblock_all_zeroes(cmd->bm, &unformatted);
        if (r)