]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
Bluetooth: btintel: Fixe build regression
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 23 Feb 2024 17:36:23 +0000 (12:36 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:01:48 +0000 (13:01 +0200)
commit 6e62ebfb49eb65bdcbfc5797db55e0ce7f79c3dd upstream.

This fixes the following build regression:

drivers-bluetooth-btintel.c-btintel_read_version()-warn:
passing-zero-to-PTR_ERR

Fixes: b79e04091010 ("Bluetooth: btintel: Fix null ptr deref in btintel_read_version")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bluetooth/btintel.c

index 75623302d00e73e78691b15210aa91037d2b9a1a..0635df202dfad12ef1a273fc133accfb08a372cf 100644 (file)
@@ -405,13 +405,13 @@ int btintel_read_version(struct hci_dev *hdev, struct intel_version *ver)
        struct sk_buff *skb;
 
        skb = __hci_cmd_sync(hdev, 0xfc05, 0, NULL, HCI_CMD_TIMEOUT);
-       if (IS_ERR_OR_NULL(skb)) {
+       if (IS_ERR(skb)) {
                bt_dev_err(hdev, "Reading Intel version information failed (%ld)",
                           PTR_ERR(skb));
                return PTR_ERR(skb);
        }
 
-       if (skb->len != sizeof(*ver)) {
+       if (!skb || skb->len != sizeof(*ver)) {
                bt_dev_err(hdev, "Intel version event size mismatch");
                kfree_skb(skb);
                return -EILSEQ;