The intent was to mask away some bits here, not to test true or false.
Fix: 
54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
 
                flag = hinfc_read(host, HINFC504_CON);
                if (chip->ecc.mode == NAND_ECC_HW)
                        hinfc_write(host,
-                                   flag && ~(HINFC504_CON_ECCTYPE_MASK <<
+                                   flag & ~(HINFC504_CON_ECCTYPE_MASK <<
                                    HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
 
                host->offset = 0;