media: cec: return -ENODEV instead of -ENXIO if unregistered

If the CEC device is unregistered, then an attempt to open
the device node should result in an -ENODEV error instead of
-ENXIO.

Document this as well in cec-func-open.rst.

This is consistent with the error code returned by other
file operations such as ioctl.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/Documentation/userspace-api/media/cec/cec-func-open.rst b/Documentation/userspace-api/media/cec/cec-func-open.rst
index d86563a34b9e779680ff9a9444e7bb7b802aff64..125c8ac6680b9653fe03004e231354c2c8cd72d3 100644 (file)
--- a/Documentation/userspace-api/media/cec/cec-func-open.rst
+++ b/Documentation/userspace-api/media/cec/cec-func-open.rst
@@ -70,5 +70,5 @@ include:
 ``ENOMEM``
     Insufficient kernel memory was available.
 
-``ENXIO``
-    No device corresponding to this device special file exists.
+``ENODEV``
+    Device not found or was removed.

diff --git a/drivers/media/cec/core/cec-core.c b/drivers/media/cec/core/cec-core.c
index 5a54db839e5d641db9d635a43a74a71e1cfe2bfd..6f940df0230c95469a99a83387c4b3cfdbbb3d97 100644 (file)
--- a/drivers/media/cec/core/cec-core.c
+++ b/drivers/media/cec/core/cec-core.c
@@ -62,12 +62,12 @@ int cec_get_device(struct cec_devnode *devnode)
         */
        mutex_lock(&devnode->lock);
        /*
-        * return ENXIO if the cec device has been removed
+        * return ENODEV if the cec device has been removed
         * already or if it is not registered anymore.
         */
        if (!devnode->registered) {
                mutex_unlock(&devnode->lock);
-               return -ENXIO;
+               return -ENODEV;
        }
        /* and increase the device refcount */
        get_device(&devnode->dev);