]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/bridge: analogix_dp: remove clk handling from analogix_dp_set_bridge
authorLucas Stach <l.stach@pengutronix.de>
Wed, 19 Jun 2024 18:21:52 +0000 (20:21 +0200)
committerRobert Foss <rfoss@kernel.org>
Thu, 27 Jun 2024 09:52:06 +0000 (11:52 +0200)
The clock is already managed by runtime PM, which is properly invoked
from the analogix_dp_set_bridge function, so there is no need for an
additional reference.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619182200.3752465-6-l.stach@pengutronix.de
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

index 7a5e25b6aa3aaa805c401055353a1611246d830d..d8c0751ab5c0f9962bcfe664ca4038d18fa787e6 100644 (file)
@@ -1251,12 +1251,6 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
 
        pm_runtime_get_sync(dp->dev);
 
-       ret = clk_prepare_enable(dp->clock);
-       if (ret < 0) {
-               DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);
-               goto out_dp_clk_pre;
-       }
-
        if (dp->plat_data->power_on)
                dp->plat_data->power_on(dp->plat_data);
 
@@ -1290,8 +1284,7 @@ out_dp_init:
        phy_power_off(dp->phy);
        if (dp->plat_data->power_off)
                dp->plat_data->power_off(dp->plat_data);
-       clk_disable_unprepare(dp->clock);
-out_dp_clk_pre:
+
        pm_runtime_put_sync(dp->dev);
 
        return ret;
@@ -1360,8 +1353,6 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
        analogix_dp_set_analog_power_down(dp, POWER_ALL, 1);
        phy_power_off(dp->phy);
 
-       clk_disable_unprepare(dp->clock);
-
        pm_runtime_put_sync(dp->dev);
 
        ret = analogix_dp_prepare_panel(dp, false, true);