]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net/mlx5e: TC, Remove mirror and ct limitation
authorPaul Blakey <paulb@nvidia.com>
Wed, 25 Jan 2023 10:01:47 +0000 (12:01 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 6 Apr 2023 01:57:33 +0000 (18:57 -0700)
Mirror action before a ct nat action was not supported when only
chain was restored on misses. As to work around that limitation,
ct action was reordered to be first (so if hw misses on ct
action, packet wasn't modified). This reordering wasn't possible
if there was mirror action before the ct nat action, as we had to
mirror the packet before the nat operation.

Now that the misses continue from the relevant tc ct action
in software and ct action is no longer reordered, this case
is supported.

Remove this limitation.

Signed-off-by: Paul Blakey <paulb@nvidia.com>
Reviewed-by: Roi Dayan <roid@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

index b6469abc7012bda213ff9bbb5c20f86ecbf93486..728b82ce4031a2b6ce3e0434064980f39985ff2e 100644 (file)
@@ -3507,19 +3507,6 @@ actions_match_supported_fdb(struct mlx5e_priv *priv,
                            struct netlink_ext_ack *extack)
 {
        struct mlx5_esw_flow_attr *esw_attr = flow->attr->esw_attr;
-       bool ct_flow, ct_clear;
-
-       ct_clear = flow->attr->ct_attr.ct_action & TCA_CT_ACT_CLEAR;
-       ct_flow = flow_flag_test(flow, CT) && !ct_clear;
-
-       if (esw_attr->split_count && ct_flow &&
-           !MLX5_CAP_GEN(esw_attr->in_mdev, reg_c_preserve)) {
-               /* All registers used by ct are cleared when using
-                * split rules.
-                */
-               NL_SET_ERR_MSG_MOD(extack, "Can't offload mirroring with action ct");
-               return false;
-       }
 
        if (esw_attr->split_count > 0 && !mlx5_esw_has_fwd_fdb(priv->mdev)) {
                NL_SET_ERR_MSG_MOD(extack,