]> www.infradead.org Git - users/hch/misc.git/commitdiff
udp_tunnel: use netdev_warn() instead of netdev_WARN()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Wed, 10 Sep 2025 19:50:26 +0000 (12:50 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 12 Sep 2025 02:09:48 +0000 (19:09 -0700)
netdev_WARN() uses WARN/WARN_ON to print a backtrace along with
file and line information. In this case, udp_tunnel_nic_register()
returning an error is just a failed operation, not a kernel bug.

udp_tunnel_nic_register() can fail due to a memory allocation
failure (kzalloc() or udp_tunnel_nic_alloc()).
This is a normal runtime error and not a kernel bug.

Replace netdev_WARN() with netdev_warn() accordingly.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250910195031.3784748-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/udp_tunnel_nic.c

index ff66db48453cf85dd0936273455460897ed7ea84..944b3cf25468ee953378666cac88698ab1fb97de 100644 (file)
@@ -930,7 +930,7 @@ udp_tunnel_nic_netdevice_event(struct notifier_block *unused,
 
                err = udp_tunnel_nic_register(dev);
                if (err)
-                       netdev_WARN(dev, "failed to register for UDP tunnel offloads: %d", err);
+                       netdev_warn(dev, "failed to register for UDP tunnel offloads: %d", err);
                return notifier_from_errno(err);
        }
        /* All other events will need the udp_tunnel_nic state */