]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: Intel: avs: Fix the minimum firmware version numbers
authorCezary Rojewski <cezary.rojewski@intel.com>
Thu, 9 Jan 2025 12:22:05 +0000 (13:22 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 9 Jan 2025 12:14:18 +0000 (12:14 +0000)
For few TGL-based platforms the minor version number for AudioDSP
firmware is incorrect forcing users to utilize ignore_fw_version module
parameter.

Fixes: 5acb19ecd198 ("ASoC: Intel: avs: TGL-based platforms support")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250109122216.3667847-3-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/core.c

index 73d4bde9b2f78839ad220c822be39bd968e6f1ac..82839d0994ee3ead578e6f0e3b2f5f360493fc42 100644 (file)
@@ -829,10 +829,10 @@ static const struct avs_spec jsl_desc = {
        .hipc = &cnl_hipc_spec,
 };
 
-#define AVS_TGL_BASED_SPEC(sname)              \
+#define AVS_TGL_BASED_SPEC(sname, min)         \
 static const struct avs_spec sname##_desc = {  \
        .name = #sname,                         \
-       .min_fw_version = { 10, 29, 0, 5646 },  \
+       .min_fw_version = { 10, min, 0, 5646 }, \
        .dsp_ops = &avs_tgl_dsp_ops,            \
        .core_init_mask = 1,                    \
        .attributes = AVS_PLATATTR_IMR,         \
@@ -840,11 +840,11 @@ static const struct avs_spec sname##_desc = {     \
        .hipc = &cnl_hipc_spec,                 \
 }
 
-AVS_TGL_BASED_SPEC(lkf);
-AVS_TGL_BASED_SPEC(tgl);
-AVS_TGL_BASED_SPEC(ehl);
-AVS_TGL_BASED_SPEC(adl);
-AVS_TGL_BASED_SPEC(adl_n);
+AVS_TGL_BASED_SPEC(lkf, 28);
+AVS_TGL_BASED_SPEC(tgl, 29);
+AVS_TGL_BASED_SPEC(ehl, 30);
+AVS_TGL_BASED_SPEC(adl, 35);
+AVS_TGL_BASED_SPEC(adl_n, 35);
 
 static const struct pci_device_id avs_ids[] = {
        { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &skl_desc) },