]> www.infradead.org Git - users/dedekind/aiaiai.git/commitdiff
Remove --check-only option support
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 3 Feb 2014 16:00:04 +0000 (18:00 +0200)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 3 Feb 2014 16:00:04 +0000 (18:00 +0200)
This patch removes the --check-only option because it is useless. I never used
it, and I did not see anyone using it.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
aiaiai-checker
aiaiai-make-kernel

index 1da8e1412cb824036d0cc1b2d2a614b5e86035d0..d071bcecb5d9d37bf19f1394c3be94fd5aff4477 100755 (executable)
@@ -31,7 +31,6 @@ Options:
       --smatch           check with smatch;
       --cppcheck         check with cppcheck;
       --coccinelle       check with coccinelle (spatch);
-      --check-only=FILE  check only files listed in FILE;
   -h, --help             show this text and exit.
 EOF
 }
@@ -90,7 +89,7 @@ cleanup_handler()
 }
 set_cleanup_handler cleanup_handler
 
-TEMP=`getopt -n $PROG -o h --long sparse,smatch,cppcheck,coccinelle,check-only:,help -- "$@"` ||
+TEMP=`getopt -n $PROG -o h --long sparse,smatch,cppcheck,coccinelle,help -- "$@"` ||
        fail_usage ""
 eval set -- "$TEMP"
 
@@ -100,7 +99,6 @@ run_sparse=
 run_smatch=
 run_cppcheck=
 run_coccinelle=
-check_only=
 
 while true; do
        case "$1" in
@@ -120,10 +118,6 @@ while true; do
                run_coccinelle=1
                program_required "spatch" "Usually Linux distribution provide a 'spatch' or 'coccinelle' package"
                ;;
-       --check-only)
-               check_only="$(opt_check_read "$1" "$2")"
-               shift
-               ;;
        -h|--help)
                show_usage
                exit 0
@@ -148,17 +142,6 @@ if [ -z "$run_sparse" ] && [ -z "$run_smatch" ] && [ -z "$run_cppcheck" ] &&
        exit 0
 fi
 
-if [ -n "$check_only" ]; then
-       match=
-       files="$(cat "$check_only")"
-       for file in $files; do
-               match="$(printf "%s" "$@" | sed -n "/$(quote_sed_regexp "$file")/p")"
-               [ -z "$match" ] || break
-       done
-
-       [ -n "$match" ] || exit 0
-fi
-
 # Run all the tools in background
 
 if [ -n "$run_sparse" ]; then
index bba99578191f2cedb913b114bd0ea7d3076b15d5..edab96a75ec9137d4fa1e05dd359be5f6da249a7 100755 (executable)
@@ -46,7 +46,6 @@ Options:
       --smatch           check with smatch while building;
       --cppcheck         check with cppcheck while building;
       --coccinelle       check with coccinelle (spatch) while building;
-      --check-only=FILE  check only files listed in FILE;
   -M, --kmake-opts       additional options to append to the final kernel
                          compilation 'make' command
                          (e.g., W=2 KALLSYMS_EXTRA_PASS=1)
@@ -108,7 +107,7 @@ make_target()
        aiaiai-locker $split -l "$lockfile" -c \
                "make $keep_going -j $jobs -C $kernel_tree ${arch:+ARCH="$arch"} \
                ${cross:+CROSS_COMPILE="$cross"} ${objdir:+O="$objdir"} \
-               CHECK=\"aiaiai-checker $sparse $smatch $cppcheck $coccinelle $check_only --\" \
+               CHECK=\"aiaiai-checker $sparse $smatch $cppcheck $coccinelle --\" \
                KCFLAGS='-Wno-missing-field-initializers -Wno-sign-compare' \
                C=$check ${check:+CF="-D__CHECK_ENDIAN__"} W=1 SHELL=\"aiaiai-locker $split -l $lockfile\" \
                $kmake_opts $target"
@@ -129,7 +128,7 @@ cleanup_handler()
 }
 set_cleanup_handler cleanup_handler
 
-TEMP=`getopt -n $PROG -o o:,D:,j:,O:,E:,k:,a:,M:,v,h --long objdir:,defconfig:,jobs:,stdout:,stderr:,keep-going,arch:,sparse,smatch,cppcheck,coccinelle,check-only:,kmake-opts:,verbose,help -- "$@"` ||
+TEMP=`getopt -n $PROG -o o:,D:,j:,O:,E:,k:,a:,M:,v,h --long objdir:,defconfig:,jobs:,stdout:,stderr:,keep-going,arch:,sparse,smatch,cppcheck,coccinelle,kmake-opts:,verbose,help -- "$@"` ||
        fail_usage ""
 eval set -- "$TEMP"
 
@@ -143,7 +142,6 @@ sparse=
 smatch=
 cppcheck=
 coccinelle=
-check_only=
 check=0
 kmake_opts=
 verbose=
@@ -199,10 +197,6 @@ while true; do
                coccinelle="--coccinelle"
                check=1
                ;;
-       --check-only)
-               check_only="--check-only $(opt_check_read "$1" "$2")"
-               shift
-               ;;
        -M|--kmake-opts)
                kmake_opts="$2"
                shift