dp83640: Make use of skb_queue_purge instead of reimplementing the code

This change makes it so that dp83640_remove can use skb_queue_purge
instead of looping through itself to flush any entries out of the queue.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 87648b3065515294c05c77ffbfddbe822fd901c2..2954052706e8bcbf0979e89772326656ba6c57fa 100644 (file)
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1136,7 +1136,6 @@ static void dp83640_remove(struct phy_device *phydev)
        struct dp83640_clock *clock;
        struct list_head *this, *next;
        struct dp83640_private *tmp, *dp83640 = phydev->priv;
-       struct sk_buff *skb;
 
        if (phydev->addr == BROADCAST_ADDR)
                return;
@@ -1144,11 +1143,8 @@ static void dp83640_remove(struct phy_device *phydev)
        enable_status_frames(phydev, false);
        cancel_work_sync(&dp83640->ts_work);
 
-       while ((skb = skb_dequeue(&dp83640->rx_queue)) != NULL)
-               kfree_skb(skb);
-
-       while ((skb = skb_dequeue(&dp83640->tx_queue)) != NULL)
-               kfree_skb(skb);
+       skb_queue_purge(&dp83640->rx_queue);
+       skb_queue_purge(&dp83640->tx_queue);
 
        clock = dp83640_clock_get(dp83640->clock);