]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
target/user: Fix size_t format-spec build warning
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 28 Feb 2016 02:25:22 +0000 (18:25 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 23 Jun 2017 04:10:48 +0000 (21:10 -0700)
Fix the following printk size_t warning as per 0-day build:

All warnings (new ones prefixed by >>):

   drivers/target/target_core_user.c: In function 'is_ring_space_avail':
>> drivers/target/target_core_user.c:385:12: warning: format '%lu'
>> expects argument of type 'long unsigned int', but argument 3 has type
>> 'size_t {aka unsigned int}' [-Wformat=]
      pr_debug("no data space: only %lu available, but ask for %lu\n",
               ^

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Orabug: 25395066
(cherry picked from commit 0241fd39ce7bc9b82b7e57305cb0d6bb1364d45b)
Signed-off-by: Kyle Fortin <kyle.fortin@oracle.com>
Reviewed-by: Shan Hai <shan.hai@oracle.com>
drivers/target/target_core_user.c

index e0e98c66323c63cb088fec0b743c4c958886edb5..b67d91bb74aec454ccd0310a7a16246002b60f63 100644 (file)
@@ -354,9 +354,8 @@ static inline size_t spc_bitmap_free(unsigned long *bitmap)
 static bool is_ring_space_avail(struct tcmu_dev *udev, size_t cmd_size, size_t data_needed)
 {
        struct tcmu_mailbox *mb = udev->mb_addr;
-       size_t space;
+       size_t space, cmd_needed;
        u32 cmd_head;
-       size_t cmd_needed;
 
        tcmu_flush_dcache_range(mb, sizeof(*mb));
 
@@ -380,7 +379,7 @@ static bool is_ring_space_avail(struct tcmu_dev *udev, size_t cmd_size, size_t d
 
        space = spc_bitmap_free(udev->data_bitmap);
        if (space < data_needed) {
-               pr_debug("no data space: only %lu available, but ask for %lu\n",
+               pr_debug("no data space: only %zu available, but ask for %zu\n",
                                space, data_needed);
                return false;
        }