kref: remove kref_set

Of the three uses of kref_set in the kernel:

 One really should be kref_put as the code is letting go of a
    reference,
 Two really should be kref_init because the kref is being
    initialised.

This suggests that making kref_set available encourages bad code.
So fix the three uses and remove kref_set completely.

Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/include/linux/kref.h b/include/linux/kref.h
index baf4b9e4b194baa43b377ee4ab681b1b38bba5cc..6cc38fc07ab76c5a052d530eec2fd31ec4d25392 100644 (file)
--- a/include/linux/kref.h
+++ b/include/linux/kref.h
@@ -21,7 +21,6 @@ struct kref {
        atomic_t refcount;
 };
 
-void kref_set(struct kref *kref, int num);
 void kref_init(struct kref *kref);
 void kref_get(struct kref *kref);
 int kref_put(struct kref *kref, void (*release) (struct kref *kref));

diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
index 076c7c8215b0e15289130fa5339bfc26dced7514..b2d70d38dff454116a3cba9dee760981f298415b 100644 (file)
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -54,8 +54,8 @@ int create_user_ns(struct cred *new)
 #endif
        /* tgcred will be cleared in our caller bc CLONE_THREAD won't be set */
 
-       /* alloc_uid() incremented the userns refcount.  Just set it to 1 */
-       kref_set(&ns->kref, 1);
+       /* root_user holds a reference to ns, our reference can be dropped */
+       put_user_ns(ns);
 
        return 0;
 }

diff --git a/lib/kref.c b/lib/kref.c
index 6d19f690380b8e3020b3a74e8fac3d2713055d0e..d3d227a08a4bdb79cae0b2f21be905451c607719 100644 (file)
--- a/lib/kref.c
+++ b/lib/kref.c
@@ -15,24 +15,14 @@
 #include <linux/module.h>
 #include <linux/slab.h>
 
-/**
- * kref_set - initialize object and set refcount to requested number.
- * @kref: object in question.
- * @num: initial reference counter
- */
-void kref_set(struct kref *kref, int num)
-{
-       atomic_set(&kref->refcount, num);
-       smp_mb();
-}
-
 /**
  * kref_init - initialize object.
  * @kref: object in question.
  */
 void kref_init(struct kref *kref)
 {
-       kref_set(kref, 1);
+       atomic_set(&kref->refcount, 1);
+       smp_mb();
 }
 
 /**
@@ -72,7 +62,6 @@ int kref_put(struct kref *kref, void (*release)(struct kref *kref))
        return 0;
 }
 
-EXPORT_SYMBOL(kref_set);
 EXPORT_SYMBOL(kref_init);
 EXPORT_SYMBOL(kref_get);
 EXPORT_SYMBOL(kref_put);

diff --git a/security/integrity/ima/ima_iint.c b/security/integrity/ima/ima_iint.c
index 2dc2d6594145473ddf31020865041777e1fa8c6f..7625b85c2274f457fc0d260a21e2d9039758d12c 100644 (file)
--- a/security/integrity/ima/ima_iint.c
+++ b/security/integrity/ima/ima_iint.c
@@ -94,7 +94,7 @@ void iint_free(struct kref *kref)
                       iint->opencount);
                iint->opencount = 0;
        }
-       kref_set(&iint->refcount, 1);
+       kref_init(&iint->refcount);
        kmem_cache_free(iint_cache, iint);
 }
 
@@ -133,7 +133,7 @@ static void init_once(void *foo)
        iint->readcount = 0;
        iint->writecount = 0;
        iint->opencount = 0;
-       kref_set(&iint->refcount, 1);
+       kref_init(&iint->refcount);
 }
 
 static int __init ima_iintcache_init(void)