media: platform: s3c-camif: Fix runtime PM imbalance on error

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Also, call pm_runtime_disable() when pm_runtime_get_sync() returns
an error code.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Sylwester Nawrocki <snawrocki@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/platform/s3c-camif/camif-core.c b/drivers/media/platform/s3c-camif/camif-core.c
index 92f43c0cbc0c0d2dbde0cdc40cc49f04dc88af02..422fd549e9c87036cb905614fc37a14e4868f894 100644 (file)
--- a/drivers/media/platform/s3c-camif/camif-core.c
+++ b/drivers/media/platform/s3c-camif/camif-core.c
@@ -464,7 +464,7 @@ static int s3c_camif_probe(struct platform_device *pdev)
 
        ret = camif_media_dev_init(camif);
        if (ret < 0)
-               goto err_alloc;
+               goto err_pm;
 
        ret = camif_register_sensor(camif);
        if (ret < 0)
@@ -498,10 +498,9 @@ err_sens:
        media_device_unregister(&camif->media_dev);
        media_device_cleanup(&camif->media_dev);
        camif_unregister_media_entities(camif);
-err_alloc:
+err_pm:
        pm_runtime_put(dev);
        pm_runtime_disable(dev);
-err_pm:
        camif_clk_put(camif);
 err_clk:
        s3c_camif_unregister_subdev(camif);