scsi: lpfc: Add missing destroy_workqueue() in error path

Add the missing destroy_workqueue() before return from
lpfc_sli4_driver_resource_setup() in the error path.

Link: https://lore.kernel.org/r/20220823044237.285643-1-yangyingliang@huawei.com
Fixes: 3cee98db2610 ("scsi: lpfc: Fix crash on driver unload in wq free")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index c69c5a0979ec4cf9bc9af41b0a6b3c5840dc90fe..55a1ad6eed03457a9479b81d3061f8764e4489e7 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -8053,7 +8053,7 @@ lpfc_sli4_driver_resource_setup(struct lpfc_hba *phba)
        /* Allocate device driver memory */
        rc = lpfc_mem_alloc(phba, SGL_ALIGN_SZ);
        if (rc)
-               return -ENOMEM;
+               goto out_destroy_workqueue;
 
        /* IF Type 2 ports get initialized now. */
        if (bf_get(lpfc_sli_intf_if_type, &phba->sli4_hba.sli_intf) >=
@@ -8481,6 +8481,9 @@ out_free_bsmbx:
        lpfc_destroy_bootstrap_mbox(phba);
 out_free_mem:
        lpfc_mem_free(phba);
+out_destroy_workqueue:
+       destroy_workqueue(phba->wq);
+       phba->wq = NULL;
        return rc;
 }