]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
authorJulien Panis <jpanis@baylibre.com>
Thu, 16 May 2024 10:44:37 +0000 (12:44 +0200)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 4 Jun 2024 17:40:51 +0000 (19:40 +0200)
Filtered mode is not supported on mt8188 SoC and is the source of bad
results. Move to immediate mode which provides good temperatures.

Fixes: f4745f546e60 ("thermal/drivers/mediatek/lvts_thermal: Add MT8188 support")
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Julien Panis <jpanis@baylibre.com>
Link: https://lore.kernel.org/r/20240516-mtk-thermal-mt8188-mode-fix-v2-1-40a317442c62@baylibre.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/thermal/mediatek/lvts_thermal.c

index 0bb3a495b56ed7756f061c710b68a7190ec504d9..82c355c466cfeccf47b60cff9891013b95a8e0de 100644 (file)
@@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(1, 1, 1, 1),
                .offset = 0x0,
-               .mode = LVTS_MSR_FILTERED_MODE,
        },
        {
                .lvts_sensor = {
@@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(1, 1, 0, 0),
                .offset = 0x100,
-               .mode = LVTS_MSR_FILTERED_MODE,
        }
 };
 
@@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(0, 1, 0, 0),
                .offset = 0x0,
-               .mode = LVTS_MSR_FILTERED_MODE,
        },
        {
                .lvts_sensor = {
@@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(1, 1, 1, 0),
                .offset = 0x100,
-               .mode = LVTS_MSR_FILTERED_MODE,
        },
        {
                .lvts_sensor = {
@@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(1, 1, 0, 0),
                .offset = 0x200,
-               .mode = LVTS_MSR_FILTERED_MODE,
        },
        {
                .lvts_sensor = {
@@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
                },
                VALID_SENSOR_MAP(1, 1, 0, 0),
                .offset = 0x300,
-               .mode = LVTS_MSR_FILTERED_MODE,
        }
 };