]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
tests: Add feature check to nvme_compare_test
authorDennis Maisenbacher <dennis.maisenbacher@wdc.com>
Thu, 17 Oct 2024 12:02:11 +0000 (12:02 +0000)
committerDaniel Wagner <wagi@monom.org>
Tue, 29 Oct 2024 06:37:41 +0000 (07:37 +0100)
Check if the NVM 'compare' command is supported before running the
nvme_compare_test which whould then fail with an 'Invalid Command
Opcode'

Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
tests/nvme_compare_test.py

index 8dfce04797860966535abcab82d4cbde74c6b1cc..a34df68e30021e818c4fe1f7362006c02abf9b38 100644 (file)
@@ -45,9 +45,20 @@ class TestNVMeCompareCmd(TestNVMeIO):
               - test_log_dir : directory for logs, temp files.
     """
 
+    def compare_cmd_supported(self):
+        """ Wrapper for extracting optional NVM 'compare' command support
+            - Args:
+                - None
+            - Returns:
+                - True if 'compare' is supported, otherwise False
+        """
+        return int(self.get_id_ctrl_field_value("oncs"), 16) & (1 << 0)
+
     def setUp(self):
         """ Pre Section for TestNVMeCompareCmd """
         super().setUp()
+        if not self.compare_cmd_supported():
+            self.skipTest("because: Optional NVM Command 'Compare' (NVMCMPS) not supported")
         self.data_size = 1024
         self.start_block = 1023
         self.setup_log_dir(self.__class__.__name__)