ASoC: amd: use int type to store negative error codes

Change the 'ret' variable from u32 to int to store negative error codes
directly or returned by other functions.

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Message-ID: <20250828075406.386208-2-rongqianfeng@vivo.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/amd/acp/acp-rembrandt.c b/sound/soc/amd/acp/acp-rembrandt.c
index aeffd24710e7d66518efa1823f12475f25f44db8..7e9c07488dcca44ebfcb9410ce3847c39acb0ed5 100644 (file)
--- a/sound/soc/amd/acp/acp-rembrandt.c
+++ b/sound/soc/amd/acp/acp-rembrandt.c
@@ -147,7 +147,7 @@ static int rembrandt_audio_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct acp_chip_info *chip;
-       u32 ret;
+       int ret;
 
        chip = dev_get_platdata(&pdev->dev);
        if (!chip || !chip->base) {

diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index e7f2a05e802cf2de61c58ba2e88e1a01e0da4edc..352485dd98b1433ce57e8e40f91d382b65b062b0 100644 (file)
--- a/sound/soc/amd/raven/acp3x-i2s.c
+++ b/sound/soc/amd/raven/acp3x-i2s.c
@@ -149,8 +149,9 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
                                int cmd, struct snd_soc_dai *dai)
 {
        struct i2s_stream_instance *rtd;
-       u32 ret, val, period_bytes, reg_val, ier_val, water_val;
+       u32 val, period_bytes, reg_val, ier_val, water_val;
        u32 buf_size, buf_reg;
+       int ret;
 
        rtd = substream->runtime->private_data;
        period_bytes = frames_to_bytes(substream->runtime,

diff --git a/sound/soc/amd/vangogh/acp5x-i2s.c b/sound/soc/amd/vangogh/acp5x-i2s.c
index 7dbe33f4b8678d1fd9850d7c25e321d4aa4c811d..bf719f6286174615bd239803eb969609c3f2fc44 100644 (file)
--- a/sound/soc/amd/vangogh/acp5x-i2s.c
+++ b/sound/soc/amd/vangogh/acp5x-i2s.c
@@ -234,8 +234,9 @@ static int acp5x_i2s_trigger(struct snd_pcm_substream *substream,
 {
        struct i2s_stream_instance *rtd;
        struct i2s_dev_data *adata;
-       u32 ret, val, period_bytes, reg_val, ier_val, water_val;
+       u32 val, period_bytes, reg_val, ier_val, water_val;
        u32 buf_size, buf_reg;
+       int ret;
 
        adata = snd_soc_dai_get_drvdata(dai);
        rtd = substream->runtime->private_data;