]> www.infradead.org Git - users/hch/misc.git/commitdiff
mm: numa_clear_kernel_node_hotplug: Add NUMA_NO_NODE check for node id
authorNobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Wed, 16 Oct 2024 09:21:01 +0000 (18:21 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 29 Oct 2024 04:40:40 +0000 (21:40 -0700)
The acquired memory blocks for reserved may include blocks outside of
memory management.  In this case, the nid variable is set to NUMA_NO_NODE
(-1), so an error occurs in node_set().  This adds a check using
numa_valid_node() to numa_clear_kernel_node_hotplug() that skips
node_set() when nid is set to NUMA_NO_NODE.

Link: https://lkml.kernel.org/r/1729070461-13576-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp
Fixes: 87482708210f ("mm: introduce numa_memblks")
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Suggested-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/numa_memblks.c

index be52b93a9c5804c8499dc6741f48482c76877b18..a3877e9bc878ad6257b658facbfab00b9f33f6ef 100644 (file)
@@ -349,7 +349,7 @@ static void __init numa_clear_kernel_node_hotplug(void)
        for_each_reserved_mem_region(mb_region) {
                int nid = memblock_get_region_node(mb_region);
 
-               if (nid != MAX_NUMNODES)
+               if (numa_valid_node(nid))
                        node_set(nid, reserved_nodemask);
        }