ath11k: Fix napi related hang

Similar to the same bug in ath10k, a napi disable w/out it being enabled
will hang forever.  I believe I saw this while trying rmmod after driver
had some failure on startup.  Fix it by keeping state on whether napi is
enabled or not.

And, remove un-used napi pointer in ath11k driver base struct.

Signed-off-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20200903195254.29379-1-greearb@candelatech.com

diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index 096c502cce3875b25b69d97ba6bc06840801ec26..3fb0aa00082594ed451b7762319fc688cd93de53 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -175,8 +175,11 @@ static void __ath11k_ahb_ext_irq_disable(struct ath11k_base *ab)
 
                ath11k_ahb_ext_grp_disable(irq_grp);
 
-               napi_synchronize(&irq_grp->napi);
-               napi_disable(&irq_grp->napi);
+               if (irq_grp->napi_enabled) {
+                       napi_synchronize(&irq_grp->napi);
+                       napi_disable(&irq_grp->napi);
+                       irq_grp->napi_enabled = false;
+               }
        }
 }
 
@@ -300,7 +303,10 @@ static void ath11k_ahb_ext_irq_enable(struct ath11k_base *ab)
        for (i = 0; i < ATH11K_EXT_IRQ_GRP_NUM_MAX; i++) {
                struct ath11k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i];
 
-               napi_enable(&irq_grp->napi);
+               if (!irq_grp->napi_enabled) {
+                       napi_enable(&irq_grp->napi);
+                       irq_grp->napi_enabled = true;
+               }
                ath11k_ahb_ext_grp_enable(irq_grp);
        }
 }

diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h
index 6d12995362e92675a8551ed18aaab6e4d58d790f..9e88ccca5ca75e629c01dacde375acd441292d58 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/core.h
+++ b/drivers/net/wireless/ath/ath11k/core.h
@@ -142,6 +142,7 @@ struct ath11k_ext_irq_grp {
        u32 num_irq;
        u32 grp_id;
        u64 timestamp;
+       bool napi_enabled;
        struct napi_struct napi;
        struct net_device napi_ndev;
 };
@@ -743,7 +744,6 @@ struct ath11k_base {
        u32 wlan_init_status;
        int irq_num[ATH11K_IRQ_NUM_MAX];
        struct ath11k_ext_irq_grp ext_irq_grp[ATH11K_EXT_IRQ_GRP_NUM_MAX];
-       struct napi_struct *napi;
        struct ath11k_targ_cap target_caps;
        u32 ext_service_bitmap[WMI_SERVICE_EXT_BM_SIZE];
        bool pdevs_macaddr_valid;

diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
index 8c09d61138a1987f07ef3a4fb02236c919895fde..d73b522a0081b17f4a557af64bd62a80ece97d8f 100644 (file)
--- a/drivers/net/wireless/ath/ath11k/pci.c
+++ b/drivers/net/wireless/ath/ath11k/pci.c
@@ -683,8 +683,11 @@ static void __ath11k_pci_ext_irq_disable(struct ath11k_base *sc)
 
                ath11k_pci_ext_grp_disable(irq_grp);
 
-               napi_synchronize(&irq_grp->napi);
-               napi_disable(&irq_grp->napi);
+               if (irq_grp->napi_enabled) {
+                       napi_synchronize(&irq_grp->napi);
+                       napi_disable(&irq_grp->napi);
+                       irq_grp->napi_enabled = false;
+               }
        }
 }
 
@@ -712,7 +715,10 @@ static void ath11k_pci_ext_irq_enable(struct ath11k_base *ab)
        for (i = 0; i < ATH11K_EXT_IRQ_GRP_NUM_MAX; i++) {
                struct ath11k_ext_irq_grp *irq_grp = &ab->ext_irq_grp[i];
 
-               napi_enable(&irq_grp->napi);
+               if (!irq_grp->napi_enabled) {
+                       napi_enable(&irq_grp->napi);
+                       irq_grp->napi_enabled = true;
+               }
                ath11k_pci_ext_grp_enable(irq_grp);
        }
 }