drm/xe: Build PM into GuC CT layer

Take PM ref when any G2H are outstanding, drop when none are
outstanding.

To safely ensure we have PM ref when in the GuC CT layer, a PM ref needs
to be held when scheduler messages are pending too.

v2:
 - Add outer PM protections to xe_file_close (CI)
v3:
 - Only take PM ref 0->1 and drop on 1->0 (Matthew Auld)
v4:
 - Add assert to G2H increment function
v5:
 - Rebase
v6:
 - Declare xe as local variable in xe_file_close (CI)

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240719172905.1527927-5-matthew.brost@intel.com

diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
index 50c302cf3249db391a23f6747a95c8ec514aff94..b677608eb592e810f09c4a4a7a39df484abbce22 100644 (file)
--- a/drivers/gpu/drm/xe/xe_device.c
+++ b/drivers/gpu/drm/xe/xe_device.c
@@ -141,11 +141,14 @@ void xe_file_put(struct xe_file *xef)
 
 static void xe_file_close(struct drm_device *dev, struct drm_file *file)
 {
+       struct xe_device *xe = to_xe_device(dev);
        struct xe_file *xef = file->driver_priv;
        struct xe_vm *vm;
        struct xe_exec_queue *q;
        unsigned long idx;
 
+       xe_pm_runtime_get(xe);
+
        /*
         * No need for exec_queue.lock here as there is no contention for it
         * when FD is closing as IOCTLs presumably can't be modifying the
@@ -162,6 +165,8 @@ static void xe_file_close(struct drm_device *dev, struct drm_file *file)
        mutex_unlock(&xef->vm.lock);
 
        xe_file_put(xef);
+
+       xe_pm_runtime_put(xe);
 }
 
 static const struct drm_ioctl_desc xe_ioctls[] = {

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 7d2e937da1d83d5f8606277c1e0cd1a74d0fe7e6..64afc90ad2c51942069efcd5ac078962a11bcce3 100644 (file)
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -327,6 +327,8 @@ static void xe_guc_ct_set_state(struct xe_guc_ct *ct,
        xe_gt_assert(ct_to_gt(ct), ct->g2h_outstanding == 0 ||
                     state == XE_GUC_CT_STATE_STOPPED);
 
+       if (ct->g2h_outstanding)
+               xe_pm_runtime_put(ct_to_xe(ct));
        ct->g2h_outstanding = 0;
        ct->state = state;
 
@@ -495,10 +497,15 @@ static void h2g_reserve_space(struct xe_guc_ct *ct, u32 cmd_len)
 static void __g2h_reserve_space(struct xe_guc_ct *ct, u32 g2h_len, u32 num_g2h)
 {
        xe_gt_assert(ct_to_gt(ct), g2h_len <= ct->ctbs.g2h.info.space);
+       xe_gt_assert(ct_to_gt(ct), (!g2h_len && !num_g2h) ||
+                    (g2h_len && num_g2h));
 
        if (g2h_len) {
                lockdep_assert_held(&ct->fast_lock);
 
+               if (!ct->g2h_outstanding)
+                       xe_pm_runtime_get_noresume(ct_to_xe(ct));
+
                ct->ctbs.g2h.info.space -= g2h_len;
                ct->g2h_outstanding += num_g2h;
        }
@@ -511,7 +518,8 @@ static void __g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len)
                     ct->ctbs.g2h.info.size - ct->ctbs.g2h.info.resv_space);
 
        ct->ctbs.g2h.info.space += g2h_len;
-       --ct->g2h_outstanding;
+       if (!--ct->g2h_outstanding)
+               xe_pm_runtime_put(ct_to_xe(ct));
 }
 
 static void g2h_release_space(struct xe_guc_ct *ct, u32 g2h_len)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 26f8c6a4f665718c4161bb29e1efc437816f4ae1..da2ead86b9ae43726174aed9e3b875368844ebf5 100644 (file)
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1413,6 +1413,8 @@ static void guc_exec_queue_process_msg(struct xe_sched_msg *msg)
        default:
                XE_WARN_ON("Unknown message type");
        }
+
+       xe_pm_runtime_put(guc_to_xe(exec_queue_to_guc(msg->private_data)));
 }
 
 static const struct drm_sched_backend_ops drm_sched_ops = {
@@ -1503,6 +1505,8 @@ static void guc_exec_queue_kill(struct xe_exec_queue *q)
 static void guc_exec_queue_add_msg(struct xe_exec_queue *q, struct xe_sched_msg *msg,
                                   u32 opcode)
 {
+       xe_pm_runtime_get_noresume(guc_to_xe(exec_queue_to_guc(q)));
+
        INIT_LIST_HEAD(&msg->link);
        msg->opcode = opcode;
        msg->private_data = q;