staging: r8188eu: don't copy ra and ta before we fail

In validate_recv_data_frame, we return an error if both to_ds and
from_ds are set in the incoming data frame. There's no need to populate
patrib->ra and ta before we return. The caller will free the received
frame, including pattrib.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220403165438.357728-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
index 47d4fd01824f22f663cb450778c088e306185404..c200e1251545a9ecf58b9edad2a873896ecb8312 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_recv.c
+++ b/drivers/staging/r8188eu/core/rtw_recv.c
@@ -974,11 +974,6 @@ static int validate_recv_data_frame(struct adapter *adapter,
                memcpy(pattrib->ta, psa, ETH_ALEN);
                ret = sta2ap_data_frame(adapter, precv_frame, &psta);
                break;
-       case 3:
-               memcpy(pattrib->ra, GetAddr1Ptr(ptr), ETH_ALEN);
-               memcpy(pattrib->ta, GetAddr2Ptr(ptr), ETH_ALEN);
-               ret = _FAIL;
-               break;
        default:
                ret = _FAIL;
                break;