vfio/mlx5: Block incremental query upon migf state error

Block incremental query which is state-dependent once the migration file
was previously marked with state error.

This may prevent redundant calls to firmware upon PRE_COPY which will
end-up with a failure and a syndrome printed in dmesg.

Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Acked-by: Leon Romanovsky <leon@kernel.org>
Link: https://lore.kernel.org/r/20240205124828.232701-5-yishaih@nvidia.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c
index 6b45bd7d89ad57159d67fa79d7974546607639b4..6800e4ffe9ee60e2367a60bbeb35364d3687eefe 100644 (file)
--- a/drivers/vfio/pci/mlx5/cmd.c
+++ b/drivers/vfio/pci/mlx5/cmd.c
@@ -121,6 +121,11 @@ int mlx5vf_cmd_query_vhca_migration_state(struct mlx5vf_pci_core_device *mvdev,
                        }
                        query_flags &= ~MLX5VF_QUERY_INC;
                }
+               /* Block incremental query which is state-dependent */
+               if (mvdev->saving_migf->state == MLX5_MIGF_STATE_ERROR) {
+                       complete(&mvdev->saving_migf->save_comp);
+                       return -ENODEV;
+               }
        }
 
        MLX5_SET(query_vhca_migration_state_in, in, opcode,