]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
platform/x86: asus-wmi: fix TUF laptop RGB variant
authorLuke D. Jones <luke@ljones.dev>
Tue, 16 Jul 2024 01:11:30 +0000 (13:11 +1200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 16 Jul 2024 09:49:09 +0000 (12:49 +0300)
In kbd_rgb_mode_store the dev_get_drvdata() call was assuming the device
data was asus_wmi when it was actually led_classdev.

This patch corrects this by making the correct chain of calls to get the
asus_wmi driver data.

Fixes: ae834a549ec1 ("platform/x86: asus-wmi: add support variant of TUF RGB")
Tested-by: Denis Benato <benato.denis96@gmail.com>
Signed-off-by: Luke D. Jones <luke@ljones.dev>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240716011130.17464-2-luke@ljones.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/asus-wmi.c

index 26c45fd093a05b3227cefbca7c3ae66a5cab7b98..cc735931f97b93be2329e2039d22994456a16584 100644 (file)
@@ -880,10 +880,14 @@ static ssize_t kbd_rgb_mode_store(struct device *dev,
                                 struct device_attribute *attr,
                                 const char *buf, size_t count)
 {
-       struct asus_wmi *asus = dev_get_drvdata(dev);
        u32 cmd, mode, r, g, b, speed;
+       struct led_classdev *led;
+       struct asus_wmi *asus;
        int err;
 
+       led = dev_get_drvdata(dev);
+       asus = container_of(led, struct asus_wmi, kbd_led);
+
        if (sscanf(buf, "%d %d %d %d %d %d", &cmd, &mode, &r, &g, &b, &speed) != 6)
                return -EINVAL;