]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: don't merge ioends across RTGs
authorChristoph Hellwig <hch@lst.de>
Mon, 8 Jul 2024 21:38:06 +0000 (14:38 -0700)
committerChristoph Hellwig <hch@lst.de>
Tue, 6 Aug 2024 13:05:16 +0000 (06:05 -0700)
Unlike AGs, RTGs don't always have metadata in their first blocks, and
thus we don't get automatic protection from merging I/O completions
across RTG boundaries.  Add code to set the IOMAP_F_BOUNDARY flag for
ioends that start at the first block of a RTG so that they never get
merged into the previous ioend.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_iomap.c

index 13cabd345e227a822126d1a321c4ff271b45884a..607d360c4a911ea40b0a3b565b72b18a3dadf6d9 100644 (file)
@@ -24,6 +24,7 @@
 #include "xfs_iomap.h"
 #include "xfs_trace.h"
 #include "xfs_quota.h"
+#include "xfs_rtgroup.h"
 #include "xfs_dquot_item.h"
 #include "xfs_dquot.h"
 #include "xfs_reflink.h"
@@ -115,7 +116,9 @@ xfs_bmbt_to_iomap(
                iomap->addr = IOMAP_NULL_ADDR;
                iomap->type = IOMAP_DELALLOC;
        } else {
-               iomap->addr = BBTOB(xfs_fsb_to_db(ip, imap->br_startblock));
+               xfs_daddr_t     bno = xfs_fsb_to_db(ip, imap->br_startblock);
+
+               iomap->addr = BBTOB(bno);
                if (mapping_flags & IOMAP_DAX)
                        iomap->addr += target->bt_dax_part_off;
 
@@ -124,6 +127,15 @@ xfs_bmbt_to_iomap(
                else
                        iomap->type = IOMAP_MAPPED;
 
+               /*
+                * Mark iomaps starting at the first sector of a RTG as merge
+                * boundary so that each I/O completions is contained to a
+                * single RTG.
+                */
+               if (XFS_IS_REALTIME_INODE(ip) && xfs_has_rtgroups(mp) &&
+                   xfs_rtb_to_rtx(mp, bno) == 0 &&
+                   xfs_rtb_to_rtxoff(mp, bno) == 0)
+                       iomap->flags |= IOMAP_F_BOUNDARY;
        }
        iomap->offset = XFS_FSB_TO_B(mp, imap->br_startoff);
        iomap->length = XFS_FSB_TO_B(mp, imap->br_blockcount);