media: pci: saa7164-vbi.c: replace if (cond) BUG() with BUG_ON()

Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-vbi.c:707:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

drivers/media/pci/saa7164/saa7164-vbi.c:760:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/pci/saa7164/saa7164-vbi.c b/drivers/media/pci/saa7164/saa7164-vbi.c
index 49d61a64c8cbe17f96d28df72674716c8043a206..cb2e09f0841d9645f55db5d392fe96b39f602bcf 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164-vbi.c
+++ b/drivers/media/pci/saa7164/saa7164-vbi.c
@@ -703,8 +703,7 @@ int saa7164_vbi_register(struct saa7164_port *port)
 
        dprintk(DBGLVL_VBI, "%s()\n", __func__);
 
-       if (port->type != SAA7164_MPEG_VBI)
-               BUG();
+       BUG_ON(port->type != SAA7164_MPEG_VBI);
 
        /* Sanity check that the PCI configuration space is active */
        if (port->hwcfg.BARLocation == 0) {
@@ -756,8 +755,7 @@ void saa7164_vbi_unregister(struct saa7164_port *port)
 
        dprintk(DBGLVL_VBI, "%s(port=%d)\n", __func__, port->nr);
 
-       if (port->type != SAA7164_MPEG_VBI)
-               BUG();
+       BUG_ON(port->type != SAA7164_MPEG_VBI);
 
        if (port->v4l_device) {
                if (port->v4l_device->minor != -1)